sameerpandey17 commented on code in PR #75635:
URL: https://github.com/apache/airflow/pull/75635#discussion_r4533439231
##########
airflow-core/src/airflow/api_fastapi/common/parameters/search.py:
##########
@@ -42,70 +42,42 @@
class _PrefixPatternParam(BaseParam[str], ABC):
"""
- Shared prefix pattern: pipe ``|`` for OR, ``~`` → empty (match all),
Unicode prefix range.
+ Shared prefix pattern: pipe ``|`` for OR, ``~`` → empty (match all), exact
prefix check.
.. note::
- Trailing non-alphanumeric characters in a search term are stripped
before the range
- is computed. A range scan with a punctuation-terminated upper bound is
unsafe under
- PostgreSQL's default locale-aware collation (``en_US.utf8`` sorts
punctuation in a
- way that breaks the range), and additionally stopping the range at an
alphanumeric
- character keeps the upper bound alphanumeric too, so the predicate
stays usable by
- default btree indexes. A user who asks for prefix ``"test_"`` gets
matches starting
- with ``"test"`` — a small over-match trade-off made explicit in the
public
+ Trailing non-alphanumeric characters in a search term are stripped
before the
+ predicate is built. Punctuation-terminated terms are unsafe under
PostgreSQL's
+ default locale-aware collation (``en_US.utf8`` sorts punctuation
unexpectedly),
+ so the term is stripped first. A user who asks for prefix ``"test_"``
gets matches
+ starting with ``"test"`` — a small over-match trade-off made explicit
in the public
``*_prefix_pattern`` query-param description.
Review Comment:
Applied your wording as suggested, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
