dhkim1920 commented on code in PR #73783:
URL: https://github.com/apache/airflow/pull/73783#discussion_r4538249728
##########
task-sdk/tests/task_sdk/execution_time/test_supervisor.py:
##########
@@ -1026,13 +1026,27 @@ def _on_child_started(self, *args, **kwargs):
spy_agency.assert_spy_not_called(heartbeat_spy)
@pytest.mark.parametrize("log_to_file", [False, True])
+ @pytest.mark.parametrize(
+ "conf_value",
+ [-(2**63), 2**64 - 1, -(2**63) - 1, 2**64, str(2**64)],
+ ids=["min-int64", "max-uint64", "below-int64", "above-uint64",
"large-number-string"],
+ )
Review Comment:
Updated as suggested. The subprocess test now uses a single representative
value, 2**64, while retaining both logging configurations, reducing the number
of subprocess runs from ten to two. The integer boundary values and numeric
string case are covered by the lightweight serialization test, which checks
that both values and types are preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
