harshthakur3 opened a new issue, #76948:
URL: https://github.com/apache/airflow/issues/76948

   ### Under which category would you file this issue?
   
   Providers
   
   ### Apache Airflow version
   
   main (development)
   
   ### What happened and how to reproduce it?
   
   With an SSH `repo_url`, `GitDagBundle.view_url_template()` removes `.git` 
from anywhere in the repository name, not just the end. The Dag source link in 
the UI, and `bundle_url` in the REST API, then point to a repository that 
doesn't exist. The HTTPS form of the same URL gives the correct link.
   
   ```python
   from airflow.providers.git.bundles.git import GitDagBundle
   
   bundle = GitDagBundle(name="dags", tracking_ref="main", 
repo_url="[email protected]:apache/airflow.github.io.git")
   print(bundle.view_url_template())
   # https://github.com/apache/airflowhub.io/tree/{version}
   ```
   
   ### What you think should happen instead?
   
   Only a trailing `.git` should be stripped, as it already is for HTTPS URLs: 
`https://github.com/apache/airflow.github.io/tree/{version}`. The cause is 
`parts[1].replace(".git", "")` in `GitDagBundle._convert_git_ssh_url_to_https`.
   
   ### Operating System
   
   _No response_
   
   ### Deployment
   
   None
   
   ### Apache Airflow Provider(s)
   
   _No response_
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Official Helm Chart version
   
   Not Applicable
   
   ### Kubernetes Version
   
   _No response_
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customizations
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

  • [I] GitDagBundle source link d... harshthakur3 (via GitHub) via commits

Reply via email to