This is an automated email from the ASF dual-hosted git repository.
jason810496 pushed a commit to branch v3-4-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v3-4-test by this push:
new aff7d660d69 [v3-4-test] Go SDK: Keep nested Conf validation test
compatible across Go versions (#75971) (#76889)
aff7d660d69 is described below
commit aff7d660d6989b440222268f62e0191b25387908
Author: Jason(Zhe-You) Liu <[email protected]>
AuthorDate: Thu Nov 12 12:42:35 2026 +0800
[v3-4-test] Go SDK: Keep nested Conf validation test compatible across Go
versions (#75971) (#76889)
(cherry picked from commit 9afb30c5a09177dd94229b622cc2f8d3e9fcf2aa)
Co-authored-by: Vincent Hsiao <[email protected]>
---
go-sdk/airflow/trigger_dag_run_test.go | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/go-sdk/airflow/trigger_dag_run_test.go
b/go-sdk/airflow/trigger_dag_run_test.go
index fdfe813c645..adee138f790 100644
--- a/go-sdk/airflow/trigger_dag_run_test.go
+++ b/go-sdk/airflow/trigger_dag_run_test.go
@@ -102,9 +102,10 @@ func buildNestedConf(depth int) map[string]any {
func TestTriggerDagRunRejectsAnInvalidSpec(t *testing.T) {
tests := []struct {
- name string
- trigger TriggerDagRunTask
- want string
+ name string
+ trigger TriggerDagRunTask
+ want string
+ wantPanicContains string
}{
{
name: "no DagID",
@@ -206,16 +207,21 @@ func TestTriggerDagRunRejectsAnInvalidSpec(t *testing.T) {
trigger: TriggerDagRun(
TriggerDagRunSpec{DagID: "downstream_etl",
Conf: buildNestedConf(10001)},
),
- want: "airflow.TriggerDagRunSpec.Conf: invalid
character '{' exceeded max depth",
+ wantPanicContains: "exceeded max depth",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
dag := Dag("etl")
- assert.PanicsWithValue(t,
- `airflow.DagRef.Task: task "trigger_downstream"
of Dag "etl": `+tt.want,
- func() { dag.Task(tt.trigger, TaskSpec{TaskID:
"trigger_downstream"}) },
- )
+ panicFunc := func() { dag.Task(tt.trigger,
TaskSpec{TaskID: "trigger_downstream"}) }
+ if tt.wantPanicContains != "" {
+ assert.Contains(t, panicMessage(t, panicFunc),
tt.wantPanicContains)
+ } else {
+ assert.PanicsWithValue(t,
+ `airflow.DagRef.Task: task
"trigger_downstream" of Dag "etl": `+tt.want,
+ panicFunc,
+ )
+ }
assert.NotPanics(t,
func() { dag.Task(extract, TaskSpec{TaskID:
"trigger_downstream"}) },
"a rejected task does not take its task_id",
