amoghrajesh commented on code in PR #76806:
URL: https://github.com/apache/airflow/pull/76806#discussion_r4546976944
##########
airflow-core/src/airflow/ui/src/pages/DagRuns/BulkClearDagRunsButton.tsx:
##########
@@ -42,13 +43,16 @@ const BulkClearDagRunsButton = ({ deselectKeys,
selectedDagRuns }: Props) => {
const { onClose, onOpen, open } = useDisclosure();
const [selectedOptions, setSelectedOptions] =
useState<Array<string>>(["existingTasks"]);
const [note, setNote] = useState<string | null>(null);
+ const [keepTaskStateDefault] = useClearKeepTaskStateDefault();
+ const [keepTaskState, setKeepTaskState] = useState(keepTaskStateDefault);
Review Comment:
Good idea. In this PR, i moved the state and checkbox into
`useKeepTaskState` and `KeepTaskStateCheckbox`, and the two run dialogs use
them now, so the bulk one resets on reopen too.
Can the two task instance dialogs move over in a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
