vishalmore90 commented on PR #73473: URL: https://github.com/apache/airflow/pull/73473#issuecomment-6816814779
Hi @rjgoyln, Thank you so much for the review and for the helpful suggestions! I have updated the PR to address all your points: 1. **Trailing newline**: Removed the extra newline so `ruff format` passes cleanly. 2. **Imports & Mock**: Removed the redundant local `BaseOperator` and `mock` imports (leveraging the module-level imports), and simplified `log` to `mock.MagicMock()`. 3. **Parametrized test**: Parametrized `test_post_execute_receives_result` over both `(self, context, result)` and `(self, context, result=None)` signatures to ensure full test coverage for both the TypeError crash and the default `None` behavior. All lint and format checks are passing cleanly. Could you please take another look when you have a moment? Thank you again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
