Andrushika commented on code in PR #76836:
URL: https://github.com/apache/airflow/pull/76836#discussion_r4547148339
##########
dev/breeze/src/airflow_breeze/utils/fork_ci_reconcile.py:
##########
@@ -828,6 +844,9 @@ def release(state: ForkState, comment: Callable[[Marker],
str]) -> Plan:
_set_ci_passed(plan, pr, passed=state == ForkState.GREEN,
target_url=target_url)
_set_ci_run_started(plan, pr, fork)
green = state in (ForkState.GREEN, ForkState.GREEN_UNVERIFIED)
+ failed_jobs = find_failed_jobs() if state == ForkState.FAILED and not
startup_failure else []
Review Comment:
This reads the run's jobs again on every monitor run while the PR stays
failed, even after the reporter recorded them. Could we skip it then?
```suggestion
failed_jobs: list[FailedJob] | None = []
if state == ForkState.FAILED and not startup_failure:
if jobs_reported is not None and marker is not None and marker.jobs
== jobs_reported:
return plan
failed_jobs = find_failed_jobs()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
