ChickenBenny commented on code in PR #76359:
URL: https://github.com/apache/airflow/pull/76359#discussion_r4549090421
##########
go-sdk/pkg/execution/task_runner.go:
##########
@@ -107,6 +109,37 @@ func RunTask(
}
}
+ timeoutSeconds, err :=
resolveExecutionTimeout(details.TIContext.ExecutionTimeout)
+ if err != nil {
+ logger.Error("Invalid execution_timeout",
+ "dag_id", details.TI.DagID,
+ "task_id", details.TI.TaskID,
+ "error", err,
+ )
+ return failTask(details.TIContext.ShouldRetry, err)
+ }
+ // Same rules as the Python task runner: zero means no timeout,
negative has already elapsed.
+ switch {
+ case timeoutSeconds == nil || *timeoutSeconds == 0:
+ case *timeoutSeconds < 0:
Review Comment:
fix with dcec4a8b0f, following your suggestion on `execution_timeout.go`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
