dabla commented on code in PR #76528:
URL: https://github.com/apache/airflow/pull/76528#discussion_r4552115672
##########
providers/ssh/docs/connections/ssh.rst:
##########
@@ -51,6 +51,9 @@ Extra (optional)
* ``timeout`` - Deprecated - use conn_timeout instead.
* ``cmd_timeout`` - Timeout (in seconds) for executing the command. The
default is 10 seconds. `null` value means no timeout.
* ``compress`` - ``true`` to ask the remote client/server to compress
traffic; ``false`` to refuse compression. Default is ``true``.
+ Neither hook reads ``Compression`` from ``~/.ssh/config``. Each
compressed connection holds about 0.3 MB of zlib state while open,
+ which adds up on a triggerer running many ``SSHRemoteJobOperator`` jobs;
to avoid it, set ``false`` on the connection those
+ operators use, knowing it also turns compression off for every other
task using that connection.
Review Comment:
Agreed. The `compress` entry now only says what holds for the connection
itself; the note about the triggerer moved to the "High Fan-out" section of the
`SSHRemoteJobOperator` page. 1119bad3b2
##########
providers/ssh/src/airflow/providers/ssh/hooks/ssh.py:
##########
@@ -722,6 +732,9 @@ def _get_value(self_val, conn_val, default=None):
"port": _get_value(self.port, conn.port, SSH_PORT),
"username": _get_value(self.username, conn.login),
"password": _get_value(self.password, conn.password),
+ # An explicit list offers zlib first, as paramiko does for
SSHHook, on every asyncssh
+ # version: 2.18 moved "none" ahead of zlib in its defaults.
+ "compression_algs": ["[email protected]", "zlib", "none"] if
self.compress else ["none"],
Review Comment:
Good idea, done in 1119bad3b2: the floor is `asyncssh>=2.18.0` and the
comment no longer explains older versions. The explicit list stays, since 2.18+
offers `none` first by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
