seanghaeli opened a new pull request, #77067:
URL: https://github.com/apache/airflow/pull/77067

   In a workgroup with managed query results, Athena keeps the results itself, 
so `GetQueryExecution` returns no `ResultConfiguration` and 
`AthenaHook.get_output_location` raised `KeyError`. It now returns `None` for 
those queries. A response with no `QueryExecution` still raises as before.
   
   `AthenaOperator` already runs these queries (sync and deferrable), and its 
lineage already skips the S3 output dataset when `output_location` is unset, so 
the only operator change is a docstring note to leave `output_location` unset 
for such a workgroup (Athena rejects a query that sets both).
   
   Checked against a real managed-results workgroup (engine version 3) with 
`airflow dags test`: an `AthenaOperator` task, then a task that reads the 
output location.
   
   Before (main):
   
   ```
   [error] Error retrieving OutputLocation. Query execution id: b4eeb1ac-...
       return 
response["QueryExecution"]["ResultConfiguration"]["OutputLocation"]
   KeyError: 'ResultConfiguration'
   DagRun Finished: dag_id=athena_managed_results, ... state=failed
   ```
   
   After (this branch):
   
   ```
   RESULT output_location: None
   RESULT rows: [{'Data': [{'VarCharValue': 'x'}]}, {'Data': [{'VarCharValue': 
'1'}]}]
   RESULT lineage outputs: []
   DagRun Finished: dag_id=athena_managed_results, ... state=success
   ```
   
   A workgroup that writes results to S3 still returns the `s3://.../<id>.csv` 
location and the S3 lineage output.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to