sdaberdaku opened a new pull request, #77121:
URL: https://github.com/apache/airflow/pull/77121

   Manually backported #76749 to `chart/v1-2x-test` after the automated 
backport failed.
   
   ## Conflict resolution
   
   `templates/workers/worker-deployment.yaml` conflicted. On this branch the 
worker is rendered from `.Values.workers.*`, the result of merging 
`workers.celery` (with unset fields removed) over the deprecated root `workers` 
section, while `main` reads `.Values.workers.celery.*` directly. The three 
template lines therefore read 
`.Values.workers.livenessProbe.terminationGracePeriodSeconds`. The value itself 
stays under `workers.celery.livenessProbe` only, as on `main`, and is not added 
to the deprecated root `workers.livenessProbe`.
   
   The values, schema and test changes applied cleanly; the tests landed in 
`helm-tests/tests/helm_tests` unchanged.
   
   ## Validation
   
   - Worker liveness probe Helm tests: **10 passed**, including the three 
backported ones.
   - `test_livenessprobe_termination_grace_period` fails against this branch's 
template without the three lines.
   - Rendering worker sets: a set with its own value gets it (45), a set 
without one inherits `workers.celery` (30), and the default worker uses 
`workers.celery` (30).
   
   related: #76749
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to