xchwan commented on code in PR #75945:
URL: https://github.com/apache/airflow/pull/75945#discussion_r4579182138
##########
chart/templates/dag-processor/dag-processor-deployment.yaml:
##########
@@ -32,10 +49,27 @@
{{- $containerSecurityContextWaitForMigrations := include
"containerSecurityContext" (list .Values.dagProcessor.waitForMigrations
.Values) }}
{{- $containerLifecycleHooks := or
.Values.dagProcessor.containerLifecycleHooks .Values.containerLifecycleHooks }}
{{- $containerLifecycleHooksLogGroomerSidecar := or
.Values.dagProcessor.logGroomerSidecar.containerLifecycleHooks
.Values.containerLifecycleHooks }}
+{{- $args := .Values.dagProcessor.args }}
+{{- $dagProcessorContext := . }}
+{{- with .Values.dagProcessor.bundleNames }}
+ {{- $definedBundles := list }}
+ {{- range $.Values.dagProcessor.dagBundleConfigList }}
+ {{- $definedBundles = append $definedBundles .name }}
+ {{- end }}
+ {{- $renderedArgs := tpl (toYaml $args) $dagProcessorContext }}
+ {{- range . }}
+ {{- if not (has . $definedBundles) }}
Review Comment:
The substring match is a bug in my check. I will compare the full
`--bundle-name` value and add a test.
For the same bundle in two sets, I would not make it a hard `fail`. The
chart already allows one bundle on several Pods (`replicas: 2`), moving a
bundle between sets needs a short overlap, and `workers.celery.sets` does not
forbid two sets on one queue either.
Instead I suggest a warning in `NOTES.txt`. I checked it on a kind cluster
with `helm install --dry-run` and `helm upgrade --dry-run=server`: with `set-a`
and `set-b` both selecting `bundle_a` it prints `Dag bundle "bundle_a" is
selected by more than one Dag processor set (set-a, set-b), so it is parsed by
each of them.`, and nothing without overlap or without sets. It is only shown
on install/upgrade (not `helm template`) and chart tests cannot cover it, so
`fail` stays for the cases that can never work (point 2).
I am fine with a hard `fail` if you prefer, as long as both set types follow
the same rule.
---
Drafted-by: Claude Code (Sonnet 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]