Dev-iL commented on code in PR #77134: URL: https://github.com/apache/airflow/pull/77134#discussion_r4579817104
########## contributing-docs/05_pull_requests.rst: ########## @@ -284,6 +284,11 @@ The runs of PRs opened from the repositories of trusted stakeholders (``astronom ``aws-mwaa/upstream-to-airflow`` and ``VladaZakharova/airflow``) are always approved, so none of the rules above apply to them. +Once a maintainer approves your PR in a review of its latest commit, its waiting runs are approved +too, whatever the rules above say: the maintainer has read the change, CI changes included. A +review of an earlier commit does not count for a later push, and neither does an approval the Review Comment: Is there a way to detect a "ui rebase" that has no code changes? If yes - I think maintainer approvals should carry over. ########## dev/breeze/doc/ci/05_workflows.md: ########## @@ -148,6 +148,16 @@ rules above apply to them, and of the rules below only the 24-hour window does: approved even when several open PRs share the head commit, or when the runs started before the PR was opened, retargeted or relabelled. +The runs of a PR whose head commit a maintainer approved are approved whatever the PR changes, as +for a trusted stakeholder. The reviewer's latest verdict on the PR must be an `APPROVED` review of +that exact commit (a later `CHANGES_REQUESTED` or a dismissal withdraws it, a comment does not), and Review Comment: > a later `CHANGES_REQUESTED` or a dismissal withdraws it Unclear: is it by the same maintainer/reviewer, or any reviewer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
