kaxil commented on a change in pull request #7249: [AIRFLOW-6626] Add email on
failure or retry to default config
URL: https://github.com/apache/airflow/pull/7249#discussion_r370553819
##########
File path: airflow/models/baseoperator.py
##########
@@ -299,8 +299,8 @@ def __init__(
task_id: str,
owner: str = conf.get('operators', 'DEFAULT_OWNER'),
email: Optional[Union[str, Iterable[str]]] = None,
- email_on_retry: bool = True,
- email_on_failure: bool = True,
+ email_on_retry: bool = conf.getboolean('email',
'default_email_on_retry'),
Review comment:
Can we add a test so that if someone modifies this code and changes it to
`conf.get` instead of `conf.getboolean`, that test should fail.
Also let's add a fallback value too so `conf.getboolean('email',
'default_email_on_retry', fallback=True)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
