amoghrajesh opened a new pull request, #77161:
URL: https://github.com/apache/airflow/pull/77161
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
closes: #71485
### What
Durable operators that also support `deferrable=True` can't reuse the
mixin's reconnect logic. `execute_resumable` makes the decision and then polls
in the worker, and a deferrable path must not poll. So that path skips the
mixin and never saves the job ID.
### Current behaviour
On the deferrable path, these operators submit the job themselves and never
write the ID to `task_state_store`:
- `RedshiftDataOperator`
- `SageMakerTrainingOperator`
- `LivyOperator`
- `DatabricksSubmitRunOperator`
- `DatabricksRunNowOperator`
- `BigQueryInsertJobOperator`
- `SnowflakeSqlApiOperator`
If the task retries while the job is still running, the retry starts a
duplicate job. Example: the trigger hits a throttling error, the task retries,
and the same SQL runs again next to the first query. `GlueJobOperator` avoids
the duplicate only by scanning its job runs page by page.
### Proposed change
`ResumableJobMixin` gets two new methods:
- `get_resume_decision(context)` returns a `ResumeDecision`: `reconnect`,
`already_succeeded` or `submit`, plus the job ID. It never submits or polls, so
it is safe to call before `defer()`.
- `persist_job_id(context, external_id)` saves a newly submitted job's ID so
a retry can find it.
`execute_resumable` now calls these two methods.
### Changes of Note
- The decision is a `NamedTuple` with a `Literal` action, not an enum or a
set of standalone functions. This keeps the new public surface to two methods
and one small type.
- Reconnect still returns whatever `poll_until_complete` returns, as before.
Returning `get_job_result()` there is a separate behaviour fix and belongs in
its own PR.
### User implications / backcompat
None. `execute_resumable` behaves the same: same logs, metrics and spans.
Only new methods are added.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]