1fanwang commented on PR #68952: URL: https://github.com/apache/airflow/pull/68952#issuecomment-6922649755
> Thanks for working on this @1fanwang. I tried a smaller version for #71485 in #77161 . It adds only `get_resume_decision()` and `persist_job_id()` to the mixin, and `execute_resumable` uses them with no change in behaviour. > > I'd rather not make the interface complex mainly for backcompat reasons. I particularly also dont like a public interface like `resume_or_submit` with 12 params! > > Would you be open to closing this in favour of that one? Would love a review too! Yes, the smaller interface makes sense. I've closed this in favor of https://github.com/apache/airflow/pull/77161. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
