aoelvp94 commented on code in PR #76921:
URL: https://github.com/apache/airflow/pull/76921#discussion_r4591447529


##########
providers/apache/arrow/src/airflow/providers/apache/arrow/hooks/adbc.py:
##########
@@ -270,6 +270,7 @@ def _resolve_execute_batch(
         sql: str,
         replace: bool,
         fast_executemany: bool,
+        matches_table_columns: bool,

Review Comment:
   Optional: this could fold into the existing flag at the call site instead of 
adding a parameter, e.g. `fast_executemany=fast_executemany and 
list(target_fields) == table_columns`, which keeps `_loader`'s signature 
unchanged. Fine either way if you prefer the separate debug message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to