arifrhm commented on code in PR #77046:
URL: https://github.com/apache/airflow/pull/77046#discussion_r4591771311


##########
providers/common/messaging/tests/unit/common/messaging/triggers/test_msg_queue.py:
##########
@@ -238,18 +246,43 @@ def test_scheme_param_does_not_set_trigger_queue(self):
         trigger = MessageQueueTrigger(scheme=PROVIDER_2_SCHEME)
         assert trigger.queue is None
 
-    @pytest.mark.usefixtures("collect_queue_param_deprecation_warning")
+    def test_queue_param_sets_trigger_queue_alongside_scheme(self):
+        """Test that the unified `queue` parameter sets the trigger queue when 
used with scheme."""
+        trigger = MessageQueueTrigger(scheme=PROVIDER_2_SCHEME, 
queue="my-trigger-queue")
+        assert trigger.scheme == PROVIDER_2_SCHEME
+        assert trigger.queue_uri is None
+        assert trigger.queue == "my-trigger-queue"
+
+    
@pytest.mark.filterwarnings("ignore::airflow.exceptions.AirflowProviderDeprecationWarning")
+    def test_queue_param_sets_trigger_queue_alongside_queue_uri(self):
+        """Test that `queue` sets the trigger queue when used alongside 
deprecated `queue_uri`."""
+        trigger = MessageQueueTrigger(queue_uri=PROVIDER_1_QUEUE, 
queue="my-trigger-queue")
+        assert trigger.queue_uri == PROVIDER_1_QUEUE
+        assert trigger.queue == "my-trigger-queue"
+
+    
@pytest.mark.filterwarnings("ignore::airflow.exceptions.AirflowProviderDeprecationWarning")
     def 
test_trigger_queue_param_sets_trigger_queue_alongside_deprecated_queue(self):
         """The deprecated `queue` (broker URI) parameter claims the `queue` 
keyword, so trigger

Review Comment:
   Updated docstring to accurately state: `Test backward compatibility when 
passing a broker URI via \`queue\` and trigger queue via deprecated 
\`trigger_queue\`.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to