baptistegh commented on code in PR #75938:
URL: https://github.com/apache/airflow/pull/75938#discussion_r4595862045


##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -345,6 +345,30 @@ def _load_help_texts_yaml() -> dict[str, dict[str, str]]:
     dest="password",
     help="The password to use for authentication",
 )
+ARG_AUTH_SSO = Arg(
+    flags=("--sso",),
+    dest="sso",
+    default=False,
+    action="store_true",
+    help="Log in through the browser with the identity provider of the API 
server, if it offers it",
+)
+ARG_AUTH_NO_BROWSER = Arg(
+    flags=("--no-browser",),
+    dest="no_browser",
+    default=False,
+    action="store_true",
+    help=(
+        "With --sso, print the login URL instead of opening a browser. The 
browser must still reach "
+        "this machine on 127.0.0.1, for example through 'ssh -L' when logged 
in remotely"
+    ),
+)
+ARG_AUTH_TIMEOUT = Arg(
+    flags=("--timeout",),
+    type=float,

Review Comment:
   The new positive_finite_float type makes the parser reject `0`, negative 
values, `inf` and  `nan`.



##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -345,6 +345,30 @@ def _load_help_texts_yaml() -> dict[str, dict[str, str]]:
     dest="password",
     help="The password to use for authentication",
 )
+ARG_AUTH_SSO = Arg(
+    flags=("--sso",),
+    dest="sso",
+    default=False,
+    action="store_true",
+    help="Log in through the browser with the identity provider of the API 
server, if it offers it",
+)
+ARG_AUTH_NO_BROWSER = Arg(
+    flags=("--no-browser",),
+    dest="no_browser",
+    default=False,
+    action="store_true",
+    help=(
+        "With --sso, print the login URL instead of opening a browser. The 
browser must still reach "
+        "this machine on 127.0.0.1, for example through 'ssh -L' when logged 
in remotely"
+    ),
+)
+ARG_AUTH_TIMEOUT = Arg(
+    flags=("--timeout",),
+    type=float,

Review Comment:
   The new `positive_finite_float` type makes the parser reject `0`, negative 
values, `inf` and  `nan`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to