kaxil commented on code in PR #77198:
URL: https://github.com/apache/airflow/pull/77198#discussion_r4602656931


##########
providers/common/ai/src/airflow/providers/common/ai/plugins/hitl_review.py:
##########
@@ -135,20 +135,20 @@ def _read_xcom_by_prefix(
                 include_node_regions=False,
             )
             entity = read.column_descriptions[0]["entity"]
-            query = read.with_only_columns(entity.key, 
entity.value).where(entity.key.like(f"{prefix}%"))
+            query = read.where(entity.key.like(f"{prefix}%"))
         else:
-            query = select(XComModel.key, XComModel.value).where(
+            query = select(XComModel).where(
                 XComModel.dag_id == dag_id,
                 XComModel.run_id == run_id,
                 XComModel.task_id == task_id,
                 XComModel.map_index == map_index,
                 XComModel.key.like(f"{prefix}%"),
             )
         result: dict[int, Any] = {}
-        for key, value in session.execute(query).all():
-            suffix = key[len(prefix) :]
+        for row in session.scalars(query):
+            suffix = row.key[len(prefix) :]
             if suffix.isdigit():
-                result[int(suffix)] = value
+                result[int(suffix)] = XCom.deserialize_value(row)

Review Comment:
   `find_session` is `async def` and already runs sync DB reads on the event 
loop. With an object-storage backend it now also does one remote read per 
output and feedback entry on every poll of the review tab, so one slow S3 call 
stalls the whole API server. Can we make it a plain `def` so FastAPI runs it in 
the threadpool, like the approve/reject endpoints?



##########
providers/common/ai/src/airflow/providers/common/ai/plugins/hitl_review.py:
##########
@@ -112,7 +112,7 @@ def _read_xcom(
         row = session.scalars(read).first()
         if row is None:
             return None
-        return row.value
+        return XCom.deserialize_value(row)

Review Comment:
   Since #74858 (on main, not released yet) a backend can implement only 
`store_value`/`load_value`, and `BaseXCom._load` picks `load_value` when it's 
preferred. Calling `deserialize_value` directly would leave those references 
unresolved here. Should this go through the same dispatch, or are 
`deserialize_value`-only backends an accepted limit for this plugin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to