This is an automated email from the ASF dual-hosted git repository.
shahar1 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8dba9c5dfd6 Speed up Dag imports by loading libcst only when needed
(#77192)
8dba9c5dfd6 is described below
commit 8dba9c5dfd67112ac2c37bc643bf4ef64cf9b106
Author: Andrew Chang <[email protected]>
AuthorDate: Wed Nov 18 05:12:36 2026 +0800
Speed up Dag imports by loading libcst only when needed (#77192)
---
.../sdk/definitions/_internal/decorators.py | 64 +++++++++++-----------
.../definitions/_internal/test_decorators.py | 18 ++++++
2 files changed, 51 insertions(+), 31 deletions(-)
diff --git a/task-sdk/src/airflow/sdk/definitions/_internal/decorators.py
b/task-sdk/src/airflow/sdk/definitions/_internal/decorators.py
index cbf42f6465e..791f65fae8b 100644
--- a/task-sdk/src/airflow/sdk/definitions/_internal/decorators.py
+++ b/task-sdk/src/airflow/sdk/definitions/_internal/decorators.py
@@ -19,8 +19,6 @@ from __future__ import annotations
import sys
-import libcst as cst
-
class _autostacklevel_warn:
def __init__(self, delta):
@@ -44,35 +42,6 @@ def fixup_decorator_warning_stack(func, delta: int = 2):
func.__globals__["warnings"] = _autostacklevel_warn(delta)
-class _TaskDecoratorRemover(cst.CSTTransformer):
- def __init__(self, task_decorator_name: str) -> None:
- self.decorators_to_remove: set[str] = {
- "setup",
- "teardown",
- "task.skip_if",
- "task.run_if",
- task_decorator_name.strip("@"),
- }
-
- def _is_task_decorator(self, decorator_node: cst.Decorator) -> bool:
- decorator_expr = decorator_node.decorator
- if isinstance(decorator_expr, cst.Name):
- return decorator_expr.value in self.decorators_to_remove
- if isinstance(decorator_expr, cst.Attribute) and
isinstance(decorator_expr.value, cst.Name):
- return f"{decorator_expr.value.value}.{decorator_expr.attr.value}"
in self.decorators_to_remove
- if isinstance(decorator_expr, cst.Call):
- return
self._is_task_decorator(cst.Decorator(decorator=decorator_expr.func))
- return False
-
- def leave_FunctionDef(
- self, original_node: cst.FunctionDef, updated_node: cst.FunctionDef
- ) -> cst.FunctionDef:
- new_decorators = [dec for dec in updated_node.decorators if not
self._is_task_decorator(dec)]
- if len(new_decorators) == len(updated_node.decorators):
- return updated_node
- return updated_node.with_changes(decorators=new_decorators)
-
-
def remove_task_decorator(python_source: str, task_decorator_name: str) -> str:
"""
Remove @task or similar decorators as well as @setup and @teardown.
@@ -80,6 +49,39 @@ def remove_task_decorator(python_source: str,
task_decorator_name: str) -> str:
:param python_source: The python source code
:param task_decorator_name: the decorator name
"""
+ # Imported here because `bases/operator.py` imports this module and libcst
is slow to load.
+ import libcst as cst
+
+ class _TaskDecoratorRemover(cst.CSTTransformer):
+ def __init__(self, task_decorator_name: str) -> None:
+ self.decorators_to_remove: set[str] = {
+ "setup",
+ "teardown",
+ "task.skip_if",
+ "task.run_if",
+ task_decorator_name.strip("@"),
+ }
+
+ def _is_task_decorator(self, decorator_node: cst.Decorator) -> bool:
+ decorator_expr = decorator_node.decorator
+ if isinstance(decorator_expr, cst.Name):
+ return decorator_expr.value in self.decorators_to_remove
+ if isinstance(decorator_expr, cst.Attribute) and
isinstance(decorator_expr.value, cst.Name):
+ return (
+
f"{decorator_expr.value.value}.{decorator_expr.attr.value}" in
self.decorators_to_remove
+ )
+ if isinstance(decorator_expr, cst.Call):
+ return
self._is_task_decorator(cst.Decorator(decorator=decorator_expr.func))
+ return False
+
+ def leave_FunctionDef(
+ self, original_node: cst.FunctionDef, updated_node: cst.FunctionDef
+ ) -> cst.FunctionDef:
+ new_decorators = [dec for dec in updated_node.decorators if not
self._is_task_decorator(dec)]
+ if len(new_decorators) == len(updated_node.decorators):
+ return updated_node
+ return updated_node.with_changes(decorators=new_decorators)
+
source_tree = cst.parse_module(python_source)
modified_tree =
source_tree.visit(_TaskDecoratorRemover(task_decorator_name))
return modified_tree.code
diff --git a/task-sdk/tests/task_sdk/definitions/_internal/test_decorators.py
b/task-sdk/tests/task_sdk/definitions/_internal/test_decorators.py
index 827e5732cf9..75953504334 100644
--- a/task-sdk/tests/task_sdk/definitions/_internal/test_decorators.py
+++ b/task-sdk/tests/task_sdk/definitions/_internal/test_decorators.py
@@ -16,6 +16,8 @@
# under the License.
from __future__ import annotations
+import subprocess
+import sys
from textwrap import dedent
import pytest
@@ -49,3 +51,19 @@ class TestExternalPythonDecorator:
res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.external_python")
assert res == expected_source
+
+
+def test_sdk_import_does_not_load_libcst():
+ code = dedent(
+ """
+ import sys
+ from airflow.sdk import DAG, task
+
+ print("libcst" in sys.modules)
+ """
+ )
+
+ result = subprocess.run([sys.executable, "-c", code], capture_output=True,
text=True, check=False)
+
+ assert result.returncode == 0, result.stderr
+ assert result.stdout.strip().splitlines()[-1] == "False"