bbovenzi opened a new pull request, #77219:
URL: https://github.com/apache/airflow/pull/77219

   Syncs pnpm to 10.34.9 everywhere the repo pins it, so lockfiles regenerated 
locally match the ones Dependabot writes.
   
   Until #76931 and #77218 merge, this diff also shows their commits. Only the 
last commit belongs here: 
[9a4473f](https://github.com/apache/airflow/pull/NUM6/commits/9a4473f275afdb0ce1c432c5a646a1aa63332d45).
 It doesn't depend on their content; it sits in the stack so the lockfile 
changes in the stack stop flipping.
   
   ### Stack
   
   This PR is part of a stack moving the UI from Prettier and ESLint to oxfmt 
and oxlint. Each open PR targets `main` and includes the commits of the open 
PRs before it, so review the PRs in order. Once a PR merges, the next one is 
rebased onto `main`.
   
   | Order | PR | Purpose |
   |---|---|---|
   | 1 | #76472 (merged) | Replace Prettier with oxfmt |
   | 2 | #76477 (merged) | Tidy the ESLint config before the oxlint move |
   | 3 | #76491 (merged) | Move most lint rules from ESLint to oxlint |
   | 4 | #76931 | Move the type-aware rules from typescript-eslint to oxlint 
(tsgolint) |
   | 5 | #77218 | Drop ESLint: the last rules run in oxlint as JS plugins or 
built-ins |
   | 6 | #NUM6 | Sync pnpm to 10.34.9 so local and Dependabot lockfiles match |
   | 7 | Not opened yet | Upgrade `typescript` to 7, once ESLint is gone and 
`pnpm codegen` supports it |
   
   
   ### Why
   Dependabot doesn't run the exact pnpm in `packageManager`. It picks a pnpm 
matching the pinned major, which has been a newer 10.x than our 10.28.1. The 
two write the lockfile differently: newer pnpm 10 keeps `libc: [glibc]` / 
`libc: [musl]` on native packages, and 10.28.1 drops them. So every Dependabot 
bump adds about 27 `libc:` lines to 
`airflow-core/src/airflow/ui/pnpm-lock.yaml` (#76941, #77034, #77045), and 
every lockfile regenerated locally removes them again (#76472, #76477). Without 
`libc`, pnpm on Linux installs both the `-gnu` and `-musl` variants of those 
packages.
   
   pnpm 10.34.9, 11 and 12 all keep the `libc` lines. This stays on 10: pnpm 11 
stops reading the `"pnpm"` field in `package.json`, where the UI keeps its 
`overrides`, `onlyBuiltDependencies` and `minimumReleaseAge`, so moving to 11 
is a migration of its own. 10.34.9 is the newest 10.x and is past the 4-day 
`minimumReleaseAge`.
   
   10.28.1 was pinned in #71516 "until we upgrade".
   
   ### What changes
   - `packageManager` in the 7 `package.json` files that pinned 10.28.1: the 
main UI, the simple auth manager UI, the React plugin template, the edge3 and 
FAB provider UIs, `ts-sdk` and the Kubernetes TypeScript example. The common.ai 
provider UI pins pnpm 9 and is left alone.
   - `PNPM_VERSION` in `scripts/docker/install_os_dependencies.sh` and the `ENV 
PNPM_VERSION` in `Dockerfile.ci`. The inlined copies in `Dockerfile` and 
`Dockerfile.ci` are regenerated by the `update-inlined-dockerfile-scripts` hook.
   - The `pnpm@…` pins in the prek configs of `airflow-core`, common.ai, edge3, 
FAB and `ts-sdk`. Most were still on 10.25.0.
   
   No lockfile changes. pnpm 10.34.9 reads the existing lockfiles as up to 
date, so it doesn't rewrite them. The missing `libc` lines come back the next 
time a package is re-resolved, from Dependabot or locally, and stay from then 
on. Forcing them back now (`--fix-lockfile`) also bumps unrelated entries, so I 
left it out.
   
   ### Checks run
   - **Install:** `pnpm install --frozen-lockfile` in the main UI runs on pnpm 
10.34.9 and accepts the existing lockfile. `pnpm install --lockfile-only` with 
10.34.9 leaves all 7 lockfiles unchanged.
   - **UI:** `pnpm lint` and `pnpm build` pass in the main UI.
   - **prek:** `prek run --stage pre-commit` passes on the changed files, 
including the main UI, simple auth manager UI and edge3 UI hooks, the FAB asset 
build and the Dockerfile inlining. `check-documented-commands` didn't run 
because my local `uv` is too old for it; the change doesn't touch documented 
commands.
   - **Not run locally:** the Docker image builds. CI rebuilds the images 
because the Dockerfiles change.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 5.5)
   
   Generated-by: Claude Code (Opus 5.5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to