yuseok89 commented on code in PR #77169:
URL: https://github.com/apache/airflow/pull/77169#discussion_r4607249818


##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -1,3 +1,4 @@
+import jinja2

Review Comment:
   Could it move down with the other imports?



##########
providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py:
##########
@@ -476,6 +477,33 @@ def test_deferred_paginated_read(self):
             **{"rows": [[3, 4], [13, 14]], "table": "NEW_HR.EMPLOYEES"},
         }
 
+    def test_do_render_template_fields_converts_strings_to_integers(self):

Review Comment:
   Would it make sense to test this through a mapped task, as the 
`SqlToS3Operator` fix did with `create_runtime_ti` and 
`.partial(...).expand(...)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to