Yanislava commented on PR #76804:
URL: https://github.com/apache/airflow/pull/76804#issuecomment-6970135270

   @shahar1 thanks for the review! Both nits are addressed in the latest 
commit: the mocked `test_get_sqlalchemy_engine` is removed (its 
username/password checks moved into the unmocked test), and `vertica_python` is 
now imported at the top of the module.
   
   I'll follow up with a separate PR for typed connection extras in the engine: 
today all extras reach the driver as URL query strings, so e.g. `log_level` 
fails and boolean extras like `{"disable_copy_local": false}` arrive as the 
string "False", which vertica-python treats as enabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to