8silvergun commented on PR #71535: URL: https://github.com/apache/airflow/pull/71535#issuecomment-6971252263
Thanks for the follow-up, and apologies for the delay. I noticed that the interrupted-clone regression test we discussed has already been implemented in #72787 (`test_interrupted_clone_version_dir_is_recovered`), although that PR was closed due to the open-PR limit. That test could be adapted for this PR without duplicating the work. One clarification from the subsequent investigation in #72922 and #72923: this PR appears to recover the missing-ref scenario from #72759, but not every interrupted-clone state. In particular, untracked working-tree files can still prevent checkout. I also noticed @akmalrashid's new report about tags pointing to commits not reachable from any branch. Using the explicit branch and tag refspecs already present in `refresh()` looks like a reasonable fix, with a separate regression test. Would you prefer keeping this PR focused on #71388 and the new tag case, while leaving broader interrupted-clone recovery to a separate change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
