phanikumv commented on code in PR #76539:
URL: https://github.com/apache/airflow/pull/76539#discussion_r4611117600
##########
task-sdk/src/airflow/sdk/execution_time/loop.py:
##########
@@ -121,8 +120,7 @@ def execute_loop_gate(gate: LoopGateOperator, context:
Context) -> None:
f"until must return a bool or LoopDecision, got
{type(result).__name__}"
)
if reason is not None:
- # Mask here, where we can know what the task has masked.
- reason = cast("str", redact(reason))
+ # The supervisor masks the reason, for a gate of every language.
Review Comment:
suggest to build suffix from redact(reason), keep the unmasked reason only
in the payload the supervisor masks, and add a test that the exception message
is masked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]