SachinyadavAug20 commented on code in PR #77209:
URL: https://github.com/apache/airflow/pull/77209#discussion_r4615870871
##########
providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -538,7 +538,12 @@ def filter_authorized_variables(
}
def get_url_login(self, **kwargs) -> str:
- return urljoin(self.apiserver_endpoint,
f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login")
+ """Return the login page url."""
+ login_url = urljoin(self.apiserver_endpoint,
f"{AUTH_MANAGER_FASTAPI_APP_PREFIX}/login")
+ next_url = kwargs.get("next_url")
Review Comment:
Good point, Core's `/auth/login` already appends `?next=` on its own.
will Reverted the change in aws_auth_manager.py.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]