[ 
https://issues.apache.org/jira/browse/AIRFLOW-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023572#comment-17023572
 ] 

ASF GitHub Bot commented on AIRFLOW-6638:
-----------------------------------------

potiuk commented on pull request #7258: [AIRFLOW-6638] Remove flakiness test 
from test_serialized_db remove
URL: https://github.com/apache/airflow/pull/7258
 
 
   The test was failing randomly because it returned the DAGs in random order 
and
   sometimes it failed because test_serialized_dag was removing only one file
   from the list of files but the file could be repeated in
   case a dag file had more than one DAG defined.
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = 
JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with 
`[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> test_serialized_dags test is flaky when removing files.
> -------------------------------------------------------
>
>                 Key: AIRFLOW-6638
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6638
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ci, serialization, tests
>    Affects Versions: 2.0.0, 1.10.7
>            Reporter: Jarek Potiuk
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to