myps6415 commented on code in PR #76737:
URL: https://github.com/apache/airflow/pull/76737#discussion_r4623373520
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -2826,8 +2826,8 @@ scheduler:
default: "5.0"
ti_metrics_interval:
description: |
- How often (in seconds) should task instance (scheduled, queued,
running and deferred) stats
- be sent to StatsD (if statsd_on is enabled)
+ How often (in seconds) should task instance (scheduled, queued,
running, deferred and
Review Comment:
Thanks for catching that! Updated scheduler.rst so the two pages agree.
##########
shared/observability/tests/observability/metrics/test_stats.py:
##########
@@ -732,16 +732,17 @@ def test_decr_emits_both_when_legacy_name_exists(self,
mock_backend):
tags={"operator_name": "EmptyOperator", "dag_id": "test_dag"},
)
- def test_gauge_emits_both_when_legacy_name_exists(self, mock_backend):
+ @pytest.mark.parametrize("stat", ["ti.scheduled", "ti.awaiting_input"])
Review Comment:
Thanks, good suggestion! Done in this PR: hoisted the set to
`TI_METRIC_STATES` and added a test that every state has a registry entry with
a `legacy_name`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]