youngduck98 commented on code in PR #75608:
URL: https://github.com/apache/airflow/pull/75608#discussion_r4623314054


##########
airflow-core/src/airflow/serialization/encoders.py:
##########
@@ -256,6 +256,7 @@ def encode_deadline_alert(d: DeadlineAlert | 
SerializedDeadlineAlert) -> dict[st
 
     return {
         "name": d.name,
+        "run_type_filter": sorted(d.run_type_filter) if d.run_type_filter is 
not None else None,

Review Comment:
   I understand the concern about unnecessary Dag version changes, but 
_try_reuse_deadline_uuids() treats a missing filter and None as equivalent, so 
I wouldn’t expect adding `run_type_filter: null` alone to trigger a new version.
   
   I included null to make the absence of a filter explicit and keep its 
meaning consistent across serialization, the API, and the UI. Is there a 
backward compatibility issue with including run_type_filter: null that I’m 
missing, especially when upgrading from an earlier Airflow version?
   
   ---
   
   fyi) I’m asking this to better understand the expectations for future 
contributions. In my experience upgrading from 3.0.6 → 3.1.3 → 3.2.2 → 3.3.0, 
the Dag version has always changed with each minor version upgrade. So I had 
assumed that Dag version changes during minor upgrades were considered 
acceptable by the community. Is that not the case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to