keith991001 commented on code in PR #72857:
URL: https://github.com/apache/airflow/pull/72857#discussion_r4623957090
##########
providers/celery/tests/unit/celery/executors/test_default_celery.py:
##########
@@ -157,6 +171,7 @@ def
test_result_backend_does_not_add_psycopg_options_to_sqlite():
("celery", "result_backend_sqlalchemy_engine_options"):
'{"pool_recycle": 1800}',
}
)
+@requires_psycopg3
Review Comment:
No. The Redis backend returns the engine options before SQLAlchemy looks up
a dialect, so this case does not need Psycopg 3. I removed the skip marker in
55757321c7. Thanks for catching this!
---
Drafted-by: Codex (GPT-6)
##########
providers/celery/tests/unit/celery/executors/test_default_celery.py:
##########
@@ -169,7 +184,462 @@ def
test_non_database_result_backend_keeps_engine_options():
("celery", "result_backend_sqlalchemy_engine_options"):
'{"pool_recycle": 1800}',
}
)
+@requires_psycopg3
Review Comment:
No. The unknown dialect raises `NoSuchModuleError` during SQLAlchemy dialect
lookup, and the configuration builder returns the original engine options
without loading Psycopg. I removed this skip marker too in 55757321c7.
---
Drafted-by: Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]