umrndem commented on code in PR #77272:
URL: https://github.com/apache/airflow/pull/77272#discussion_r4624628131


##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_job.py:
##########
@@ -1310,12 +1327,24 @@ def test_get_pods_retry(
             side_effects.append(k8s.V1PodList(items=items))
         mock_client.return_value.list_namespaced_pod.side_effect = side_effects
 
-        op = KubernetesJobOperator(task_id="faketask", parallelism=1, 
discover_pods_retry_number=retries)
+        options = {} if delay is None else {"discover_pods_retry_delay": delay}
+        op = KubernetesJobOperator(
+            task_id="faketask", parallelism=1, 
discover_pods_retry_number=retries, **options
+        )
 
-        result = op.get_pods(mock.MagicMock(), mock_context)
+        if successful_try is None:
+            with pytest.raises(AirflowException, match="No pods running with 
labels"):
+                op.get_pods(mock.MagicMock(), mock_context)
+            expected_retries = retries
+        else:
+            assert op.get_pods(mock.MagicMock(), mock_context) == return_value
+            expected_retries = successful_try
 
-        assert result == return_value
-        assert mock_client.return_value.list_namespaced_pod.call_count == 
successful_try + 1
+        assert mock_client.return_value.list_namespaced_pod.call_count == 
expected_retries + 1
+        expected_delay = 2 if delay is None else delay
+        assert mock_sleep.call_args_list == (
+            [mock.call(expected_delay)] * expected_retries if expected_delay 
else []

Review Comment:
   yep, i added a test that checks the constructor rejects negative delays.
   
   ---
   Drafted-by: OpenAI Codex (no human review before posting)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to