PCTEJA opened a new pull request, #77290: URL: https://github.com/apache/airflow/pull/77290
The triggerer uploads each finished trigger's log inline on its main loop, so when many triggers finish together the uploads block heartbeating and healthy triggers can be reassigned. This moves the upload and close work to a small thread pool (4 workers) in `TriggerRunnerSupervisor`. Pending uploads are tracked by log path, and creating a workload for a new trigger that reuses a log path with an upload still in flight is deferred to the next pass, so the new logger cannot truncate the file mid-upload. closes: #77278 Testing: - Reproduced on main: one message with 400 finished triggers at 0.1s per simulated upload blocked `_handle_request` for 40.1s. With this change it returns in about 0s. - Full `airflow-core/tests/unit/jobs/test_triggerer_job.py`: 213 passed, 1 skipped. Both new tests fail on base code. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — ChatGPT Astra Generated-by: ChatGPT Astra following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
