jroachgolf84 commented on code in PR #74452:
URL: https://github.com/apache/airflow/pull/74452#discussion_r4629581574


##########
providers/http/src/airflow/providers/http/hooks/http.py:
##########
@@ -54,10 +54,14 @@
 
 
 def _url_from_endpoint(base_url: str | None, endpoint: str | None) -> str:

Review Comment:
   Should we do something a bit more straightforward, like this?
   
   ```python
       if not base_url or not endpoint:
           return (base_url or "") + (endpoint or "")
   
       else:
           return base_url.strip("/") + "/" + endpoint.strip("/")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to