[ 
https://issues.apache.org/jira/browse/AIRFLOW-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024954#comment-17024954
 ] 

Qian Yu commented on AIRFLOW-6657:
----------------------------------

[~kaxilnaik] [~ash] [~chronitis] 

It is not clear to me why the plan to implement {{BranchPythonOperator}} as 
{{BaseBranchOperator was abandoned. It looks worth doing to me. So I'm going to 
put up a PR for it.}}

> Implement BranchPythonOperator as BaseBranchOperator
> ----------------------------------------------------
>
>                 Key: AIRFLOW-6657
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6657
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.10.4
>            Reporter: Qian Yu
>            Assignee: Qian Yu
>            Priority: Major
>
> This PR added a base class {{BaseBranchOperator}} that is intended to let 
> people implement custom branching logic as its subclasses. 
> https://github.com/apache/airflow/pull/5231
> However the existing {{BranchPythonOperator}} is implemented on its own, not 
> utilizing {{BaseBranchOperator}}.
> This is making other JIRAs difficult to continue. E.g. this one AIRFLOW-5391. 
> Should subsequent JIRAs be working on {{BranchPythonOperator}} or 
> {{BaseBranchOperator}} or both?
> There was a discussion about implementing {{BranchPythonOperator}} as 
> {{BaseBranchOperator}}. However, the discussion did not continue to implement 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to