ashb commented on a change in pull request #5659: [AIRFLOW-5033] Switched to
snakebite-py3
URL: https://github.com/apache/airflow/pull/5659#discussion_r372291742
##########
File path: scripts/ci/_utils.sh
##########
@@ -640,27 +640,30 @@ function run_flake8() {
if [[ "${#FILES[@]}" == "0" ]]; then
docker run "${AIRFLOW_CONTAINER_EXTRA_DOCKER_FLAGS[@]}" \
- --entrypoint "/usr/local/bin/dumb-init" \
+ --init \
--env PYTHONDONTWRITEBYTECODE \
--env AIRFLOW_CI_VERBOSE="${VERBOSE}" \
--env AIRFLOW_CI_SILENT \
--env HOST_USER_ID="$(id -ur)" \
--env HOST_GROUP_ID="$(id -gr)" \
+ --entrypoint \
+ "/opt/airflow/scripts/ci/in_container/run_flake8.sh" \
--rm \
"${AIRFLOW_CI_IMAGE}" \
- "--" "/opt/airflow/scripts/ci/in_container/run_flake8.sh" \
| tee -a "${OUTPUT_LOG}"
else
docker run "${AIRFLOW_CONTAINER_EXTRA_DOCKER_FLAGS[@]}" \
- --entrypoint "/usr/local/bin/dumb-init" \
+ --init \
Review comment:
Oh I didn't even know about this option. Nice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
