mustafagok commented on a change in pull request #7263: [AIRFLOW-XXXX] Improve
docstring of AwsHook
URL: https://github.com/apache/airflow/pull/7263#discussion_r372640341
##########
File path: airflow/contrib/hooks/aws_hook.py
##########
@@ -40,10 +40,14 @@ class AwsHook(BaseHook):
Interact with AWS.
This class is a thin wrapper around the boto3 python library.
- :param str aws_conn_id: The Airflow connection used for AWS credentials.
- If this is None then the default boto3 behaviour is used. If running
Airflow
- in a distributed manner and aws_conn_id is None, then default boto3
configuration
- would be used (and must be maintained on each worker node).
+ :param aws_conn_id: The Airflow connection used for AWS credentials.
+ If this is None then the default boto3 behaviour is used. If running
Airflow
+ in a distributed manner and aws_conn_id is None, then default boto3
configuration
+ would be used (and must be maintained on each worker node).
+ :type aws_conn_id: str
+ :param verify: Whether or not to verify SSL certificates.
+
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/core/session.html
+ :type verify: str or bool
Review comment:
I am open for suggestions :)
boto3 docs: verify (boolean/string)
it could be `Union[str, bool]`, also PyCharm quick documentation (ctrl+q)
renders `str or bool` as `Union[str, bool]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
