larryzhu2018 commented on issue #7141: [AIRFLOW-6544] add log_id to end_of_log 
mark log record
URL: https://github.com/apache/airflow/pull/7141#issuecomment-579987877
 
 
   > There's a lot of disagreement going on here.
   > 
   > @larryzhu2018 Can you please give me DETAILED instructions on how to test 
this bug and your fix locally, assujming I have _no_ current elasticsearch or 
kibana set up currently. (Docker would be preferred.)
   
   Please note that I did not change the production code here. I only reverted 
Ping's recent fix that broke logging using elastic search. I also provided unit 
test case that tests the log_id logic, show how log_id is used and I also 
showed here the ingest processor we use so any one who has an elasticsearch can 
copy and paste and try it out. Is this sufficient? I won't have time to add 
docker, and elastic ingestion nodes etc as I did not add the elastic-search 
logging support myself. I only reverted a recent change because the authors did 
not understand the code logic or how it is supposed to work. Do you see the 
community service I provided here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to