lucafuji commented on a change in pull request #6870: [AIRFLOW-0578] Check 
return code
URL: https://github.com/apache/airflow/pull/6870#discussion_r372669508
 
 

 ##########
 File path: airflow/jobs/local_task_job.py
 ##########
 @@ -95,6 +95,15 @@ def signal_handler(signum, frame):
                 # Monitor the task to see if it's done
                 return_code = self.task_runner.return_code()
                 if return_code is not None:
+                    print(self.task_instance.state)
+                    # there is one case we should not treat non zero return
+                    # code as failed: the job has been killed externally.
 
 Review comment:
   Not sure what I got you,  
   in those cases I think we should mark them as failure as well?  Anyway they 
means we have some problems in running the task then we should raise an 
exception here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to