anitakar commented on a change in pull request #7296: [AIRFLOW-6683] Make REST 
API respect store_serialized_dag setting
URL: https://github.com/apache/airflow/pull/7296#discussion_r373047376
 
 

 ##########
 File path: airflow/api/common/experimental/trigger_dag.py
 ##########
 @@ -122,7 +122,14 @@ def trigger_dag(
     dag_model = DagModel.get_current(dag_id)
     if dag_model is None:
         raise DagNotFound("Dag id {} not found in DagModel".format(dag_id))
-    dagbag = DagBag(dag_folder=dag_model.fileloc)
+    try:
+        store_serialized_dags = conf.getboolean('core', 
'store_serialized_dags')
+    except Exception:
+        store_serialized_dags = False
 
 Review comment:
   It was another conf. It was argument from POST body to DAG run.
   For:
   curl -X POST http://localhost:8080/api/experimental/dags/tutorial/dag_runs 
-H 'Cache-Control: no-cache' -H 'Content-Type: application/json' -d 
'{"conf":"{\"key\":\"value\"}"}'
   It would have been:
   {"key":"value"}
   Unit test fails. My end to end test fails.
   It is work in progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to