TV4Fun commented on issue #7098: [AIRFLOW-4453] Make behavior of `none_failed` 
consistent with documentation
URL: https://github.com/apache/airflow/pull/7098#issuecomment-580496345
 
 
   @yuqian90, you do raise a valid point. I see one of two possible solutions 
then:
   
   1. Keep the current behavior of `none_failed` and create a new trigger rule 
(`none_failed_including_skips` maybe? I don't know) that behaves as in this PR. 
I saw keep the current behavior for `none_failed` so as to minimize the amount 
of refactoring we make people do, even though from a documentation perspective, 
it would make more sense to change the behavior of `none_failed` and move the 
current behavior to a new operator like `none_failed_one_success` or something 
like that just because this behavior is more in line with the intuitive reading 
of `none_failed` and less likely to cause confusion.
   
   2. It is easy if slightly annoying to work around this by giving an operator 
with a `none_failed` trigger rule a single upstream `DummyOperator` dependency 
so that it has at least one success. If we just want to keep the status quo, we 
definitely want to update the documentation to make it clear what the actual 
behavior is and how to get the current documented behavior if you want it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to