[
https://issues.apache.org/jira/browse/AIRFLOW-6005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17027288#comment-17027288
]
ASF GitHub Bot commented on AIRFLOW-6005:
-----------------------------------------
potiuk commented on pull request #6597: [AIRFLOW-6005] Common classes should
always be imported from airflow, Depends on [AIRFLOW-6128]
URL: https://github.com/apache/airflow/pull/6597
NOTE FOR REVIEWER: This change depends on #6596 #6702 #6696 so please
review only the last commit.
For the sake of consistency, all the common components exposed directly
in 'airflow' __init__.py should be imported from there rather than
from sub-packages. This is important also for back-porting
purposes (AIP-21) to make sure that we are using stable imports.
This change does it and implements pre-commit that prevents importing
those common imports differently.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6005
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Common classes should always be imported from airflow
> -----------------------------------------------------
>
> Key: AIRFLOW-6005
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6005
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: ci
> Affects Versions: 2.0.0
> Reporter: Jarek Potiuk
> Assignee: Jarek Potiuk
> Priority: Major
>
> Common classes imported in 'airflow.__init__.py' should always be imported
> directly from 'airflow' package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
