potiuk commented on a change in pull request #7328: [AIRFLOW-6707] Simplify Connection.get_hook method URL: https://github.com/apache/airflow/pull/7328#discussion_r373843156
########## File path: airflow/models/connection.py ########## @@ -28,6 +28,50 @@ from airflow.models.base import ID_LEN, Base from airflow.models.crypto import get_fernet from airflow.utils.log.logging_mixin import LoggingMixin +from airflow.utils.module_loading import import_string + +# A map that assigns a connection type to a tuple that contains +# the path of the class and the name of the conn_id key parameter. +# PLEASE KEEP BELOW LIST IN ALPHABETICAL ORDER. Review comment: It should be easy as as of python 3.6 all the dicts are ordered by insertion order https://stackoverflow.com/questions/39980323/are-dictionaries-ordered-in-python-3-6 so our tests should just test if keys() are sorted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
