BasPH commented on a change in pull request #7336: [AIRFLOW-4364] Make all code
in airflow/providers/amazon pylint compatible
URL: https://github.com/apache/airflow/pull/7336#discussion_r373864638
##########
File path: airflow/providers/amazon/aws/operators/ecs.py
##########
@@ -201,7 +215,7 @@ def _check_success_task(self):
# This is a `stoppedReason` that indicates a task has not
# successfully finished, but there is no other indication of
failure
# in the response.
- # See,
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/stopped-task-errors.html
# noqa E501
+ # See,
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/stopped-task-errors.html
# noqa: E501 # pylint: disable=line-too-long
Review comment:
Turns out it's because `See, ` is not captured by the regex:
```
^\s*(# )?<?https?://\S+>?$
```
Only long lines where https://.... is directly after the # are ignored.
I could change the regex to include any characters after # and before
https://:
```
^\s*(# )?.*<?https?://\S+>?$
```
Or just leave this case as it is right now (or remove "See, " from this
line), WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
