potiuk commented on a change in pull request #7292: [AIRFLOW-6678] Pull event
logs from Kubernetes pod on failure
URL: https://github.com/apache/airflow/pull/7292#discussion_r374155152
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -170,6 +172,7 @@ def __init__(self, # pylint:
disable=too-many-arguments,too-many-locals
schedulername: Optional[str] = None,
full_pod_spec: Optional[k8s.V1Pod] = None,
init_containers: Optional[List[k8s.V1Container]] = None,
+ log_events_on_failure: bool = True,
Review comment:
I think for backwards compatibility we could set it to False, though i am on
the fence on this one. It's super-useful and it does not change the behaviour
of the pod launcher but it prints useful log files on failure, so I am not sure
if backwards compatibility is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
