[
https://issues.apache.org/jira/browse/AIRFLOW-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030619#comment-17030619
]
ASF GitHub Bot commented on AIRFLOW-6733:
-----------------------------------------
ashb commented on pull request #7366: [AIRFLOW-6733] Extend not replace template
URL: https://github.com/apache/airflow/pull/7366
We had copied whole-sale the baselayout.html from FAB and customized it, but
pre-existing mechanism in flask/jinja of template inheritance means we don't
have to do this.
We can instead extend the template from FAB and change the few blocks we
need to.
I have written this PR as two commits -- one to move the file without any
changes (we can't extend `appbuilder/baselayout.html` from FAB while our file
exists, as that is "earlier" in the template search path) and then a second
commit that keeps just the blocks we have extended/changed.
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Extend, don't replace FAB layout template
> -----------------------------------------
>
> Key: AIRFLOW-6733
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6733
> Project: Apache Airflow
> Issue Type: Improvement
> Components: webserver
> Affects Versions: 1.10.9
> Reporter: Ash Berlin-Taylor
> Priority: Minor
>
> This is a minor tidy-up of the templates. Right now we don't set the
> base_template of the appbuilder, but instead we replace the whole file
> earlier in the search path.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
