ashb commented on a change in pull request #7232: [AIRFLOW-6569] Flush pending
Sentry exceptions before exiting forked process
URL: https://github.com/apache/airflow/pull/7232#discussion_r375402282
##########
File path: airflow/sentry.py
##########
@@ -149,6 +154,10 @@ def wrapper(task_instance, *args, session=None, **kwargs):
return wrapper
+ def flush(self):
+ from sentry_sdk import Hub
+ Hub.current.flush()
Review comment:
Should we be calling
https://github.com/getsentry/sentry-python/blob/68ddcf459078f892ee25fbc354c9044057fbd0ef/sentry_sdk/api.py#L221-L229
instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
