mik-laj commented on a change in pull request #7389: [AIRFLOW-6763] Make systems tests ready for backport tests URL: https://github.com/apache/airflow/pull/7389#discussion_r376828926
########## File path: TESTING.rst ########## @@ -474,20 +473,58 @@ More information: Airflow System Tests ==================== -The System tests for Airflow are not yet fully implemented. They are Work In Progress of the -`AIP-4 Support for System Tests for external systems <https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-4+Support+for+System+Tests+for+external+systems>`__. These tests need to communicate with external services/systems that are available if you have appropriate credentials configured for your tests. -The tests derive from ``tests.system_test_class.SystemTests`` class. +The tests derive from ``tests.system_test_class.SystemTests`` class. They should also +be marked with ``@pytest.marker.system(SYSTEM)`` where system designates the system +to be tested (for example ``google.cloud``). Those tests are skipped by default. +You can execute the tests providing ``--systems SYSTEMS`` flag to pytest. -The system tests execute a specified -example DAG file that runs the DAG end-to-end. +The system tests execute a specified example DAG file that runs the DAG end-to-end. + +Most of the system tests have also addtional requirements for example they need to have Review comment: I think it is very dangerous that this key is available in the container, and certainly not acceptable if we want to finish AIP-4. I have an idea that we can discuss tomorrow in the office. This will remove the need for key files in the container and even on the developer's computer. However, this is a separate topic that we can implement independently. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
