dimberman commented on a change in pull request #6230: [AIRFLOW-5413] Allow K8S
worker pod to be configured from JSON/YAML file
URL: https://github.com/apache/airflow/pull/6230#discussion_r377744737
##########
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##########
@@ -126,22 +126,25 @@ class KubernetesPodOperator(BaseOperator): # pylint:
disable=too-many-instance-
:type schedulername: str
:param full_pod_spec: The complete podSpec
:type full_pod_spec: kubernetes.client.models.V1Pod
- :param do_xcom_push: If True, the content of the file
- /airflow/xcom/return.json in the container will also be pushed to an
- XCom when the container completes.
- :type do_xcom_push: bool
:param init_containers: init container for the launched Pod
:type init_containers: list[kubernetes.client.models.V1Container]
:param log_events_on_failure: Log the pod's events if a failure occurs
:type log_events_on_failure: bool
+ :param do_xcom_push: If True, the content of the file
+ /airflow/xcom/return.json in the container will also be pushed to an
+ XCom when the container completes.
+ :type do_xcom_push: bool
+ :param pod_template_file: path to pod template file
+ :type pod_template_file: str
"""
- template_fields = ('cmds', 'arguments', 'env_vars', 'config_file')
+ template_fields = ('cmds', 'arguments', 'env_vars', 'config_file',
'pod_template_file')
+ template_ext = ('.yaml', '.yml')
Review comment:
I don't think this would be a problem (though it gives some more flexibility
to the users that they need to be careful with). I could see a situation where
based on certain settings I might want to use a different pod configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
