mik-laj commented on a change in pull request #7400: [AIRFLOW-6759] Added
MLEngine operator/hook to cancel MLEngine jobs
URL: https://github.com/apache/airflow/pull/7400#discussion_r377755518
##########
File path: airflow/providers/google/cloud/operators/mlengine.py
##########
@@ -1015,3 +1015,58 @@ def check_existing_job(existing_job):
if finished_training_job['state'] != 'SUCCEEDED':
self.log.error('MLEngine training job failed: %s',
str(finished_training_job))
raise RuntimeError(finished_training_job['errorMessage'])
+
+
+class MLEngineTrainingJobFailureOperator(BaseOperator):
+
+ """
+ Operator for cleaning up failed MLEngine training job.
+
+ :param job_id: A unique templated id for the submitted Google MLEngine
+ training job. (templated)
+ :type job_id: str
+ :param project_id: The Google Cloud project name within which MLEngine
training job should run.
+ If set to None or missing, the default project_id from the GCP
connection is used. (templated)
Review comment:
All operators except BigQuery allow passing project_id as a parameter.
However, if this parameter is omitted, the default value will be read from the
credentials.
https://github.com/apache/airflow/blob/97a429f/airflow/providers/google/cloud/hooks/base.py#L334-L360
It is very difficult to authorize and not get project_id. This is not even
possible with production deployment. You may not have project_id when using
gcloud for authorization only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
